Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: make the service worker optional, prefer network when online #20425

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

docs: make the service worker optional, prefer network when online #20425

wants to merge 2 commits into from

Conversation

KaelWD
Copy link
Member

@KaelWD KaelWD commented Sep 4, 2024

No description provided.

@userquin
Copy link
Member

userquin commented Sep 4, 2024

Check https://vercel.com/docs/edge-network/headers#cache-control
@KaelWD
Copy link
Member Author

KaelWD commented Sep 4, 2024

I think that's if you only specify s-maxage
userquin
userquin reviewed Sep 5, 2024
View reviewed changes
packages/docs/vite.config.mts
injectManifest: {
globIgnores: ['**/*.html'],
additionalManifestEntries: [
{ url: '/_fallback.html', revision: Date.now().toString(16) },
],
dontCacheBustURLsMatching: /assets\/.+[A-Za-z0-9]{8}\.(js|css)$/,
dontCacheBustURLsMatching: /assets\/.+-[A-Za-z0-9_-]{8}\.(js|css)$/,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cannot just use /assets\// adding **/*.map to globIgnores?

globIgnores: ['**/*.html', '**/*.map'],
dontCacheBustURLsMatching: /assets\//,
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@KaelWD @userquin