stop AutoInstallerFs from thrashing forevermore and fix typings installer #225648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjbvz
approved these changes
Aug 15, 2024
roblourens
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets the AutoInstallerFs and ATA working. Previously, it was thrashing like whoa, but now only a single package management operation is done at a time, and the thundering herd just waits for that one shared operation to complete, instead of queueing new ones.
The only thing I can't seem to get this to do is to re-install and refresh types/definitions when package.json changes or when a new dependency is imported. Not sure what's up with that, but I think that problem can be solved separately.
/cc @mattbierner