Improve extension README preview markdown codeblock language detection
#205329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #205328
after attempting to match a language alias against the whole line (and failing)
it will fall back to attempting to match only the initial (whitespace separated) language name
the intention for this is for my extension
json textmateis a subset of normaljsonI wanted to put a codeblock in displaying some
json textmatecodebut if my extension isn't installed, I wanted it to default back to normal
jsonwhich is what Github and the builtin Markdown extension does
but the extension
README.mdpreview does notlang.split(/\s+|:|,|(?!^)\{|\?]/, 1)[0]splits the language line once on one of the following symbols
:,{?then returns the first section
(leading whitespace is already stripped from the lang line)