-
Notifications
You must be signed in to change notification settings - Fork 28.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass the check if any one of the library (of the arch) satisfies the requirement. #204221
Conversation
@microsoft-github-policy-service agree |
Pinging @deepak1556 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, thanks!
The loop over I've no system with more than one |
Thanks for confirming! |
@deepak1556 The suggestions all look good to me. Do I need to commit the suggestions or resolve the comments? |
Feel free to do either, commit suggestions from github or make the changes locally and commit them (which will also resolve the comments) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
I like your exit checks. Easier to read! Thanks for all the efforts on VSCode! |
Pass the check if one of the library (of the arch) satisfies the requirement.
Co-authored-by: Robo <hop2deep@gmail.com>
Co-authored-by: Robo <hop2deep@gmail.com>
Co-authored-by: Robo <hop2deep@gmail.com>
Co-authored-by: Robo <hop2deep@gmail.com>
Co-authored-by: Robo <hop2deep@gmail.com>
Co-authored-by: Robo <hop2deep@gmail.com>
e09b14f
Pass the check if any one of the library (of the arch) satisfies the requirement.
Fixes microsoft/vscode-remote-release#9475