Bump to Compose alpha September release for 1.7.x track #2379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yschimke
reviewed
Sep 10, 2024
gradle/libs.versions.toml
Outdated
| @@ -138,7 +138,7 @@ coil-test = { module = "io.coil-kt:coil-test", version.ref = "io-coil-kt" } | |||
| com-squareup-okhttp3-logging-interceptor = { module = "com.squareup.okhttp3:logging-interceptor", version.ref = "com-squareup-okhttp3" } | |||
| com-squareup-okhttp3-okhttp = { module = "com.squareup.okhttp3:okhttp", version.ref = "com-squareup-okhttp3" } | |||
| com-squareup-okhttp3-mockwebserver = { module = "com.squareup.okhttp3:mockwebserver", version.ref = "com-squareup-okhttp3" } | |||
| compose-bom = "androidx.compose:compose-bom:2024.09.00" | |||
| compose-bom = "androidx.compose:compose-bom:2024.09.00-alpha" | |||
| compose-animation-animationgraphics = { module = "androidx.compose.animation:animation-graphics", version.ref = "compose" } | |||
There was a problem hiding this comment.
Can we strip versions from some of the dependencies? This can just come from the BOM now.
There was a problem hiding this comment.
Ah okay! Yeah I can fix that :) Thanks!
There was a problem hiding this comment.
I tired to move all compose related dependencies to BOM now, but it required us using the BOM in more modules. Can revert that if there are specific reasons not to use BOM for these modules :)
oas004
commented
Sep 10, 2024
Comment on lines
16
to
+17
| androidxCore = "1.13.1" | ||
| androidxComposeBom = "2024.09.00-alpha" |
yschimke
approved these changes
Sep 10, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Bump to Compose alpha track for 1.7.x releases
WHY
resolves #2374
HOW
Bumping the version, running the sample apps and the tasks in contribution.md
Checklist 📋